Skip to content

Conversation

@Gasoonjia
Copy link
Contributor

@Gasoonjia Gasoonjia commented Jan 5, 2026

Stack from ghstack (oldest at bottom):

Add as_strided() and as_strided_() view operations that allow creating
views of a tensor with different sizes, strides, and storage offset.
Views share the same underlying storage.

Changes:

  • Create c10/core/WrapDimMinimal.h for dimension wrapping
  • Create core/SlimTensorView-incl.h with as_strided implementations
  • Add as_strided() and as_strided_() methods to SlimTensor
  • Add set_sizes_and_strides() overload that takes storage_offset
  • Update build targets to include new headers

Differential Revision: D89951036

Add as_strided() and as_strided_() view operations that allow creating
views of a tensor with different sizes, strides, and storage offset.
Views share the same underlying storage.

Changes:
- Create c10/core/WrapDimMinimal.h for dimension wrapping
- Create core/SlimTensorView-incl.h with as_strided implementations
- Add as_strided() and as_strided_() methods to SlimTensor
- Add set_sizes_and_strides() overload that takes storage_offset
- Update build targets to include new headers

Differential Revision: [D89951036](https://our.internmc.facebook.com/intern/diff/D89951036/)

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 5, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16443

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 4 New Failures, 2 Unrelated Failures

As of commit 4ec6462 with merge base fd6fa87 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions
Copy link

github-actions bot commented Jan 5, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 5, 2026
This was referenced Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants