[ET-VK][testing] Fix qdq8ta_conv2d_activations test failures via configurable shader filtering #16402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…igurable shader filtering The qdq8ta_conv2d_activations correctness tests were failing because the GPU timing collection function was filtering out quantize_and_pack_4w4c and unpack_4w4c_and_dequantize shaders from timing measurements. For these tests, these shaders ARE the operations being tested, not overhead. This change refactors shader filtering to be configurable per test case: - Added shader_filter member to TestCase class with getter/setter methods - Created kDefaultShaderFilter (filters layout conversions + quantization) for backward compatibility - Created kLayoutOnlyShaderFilter (filters only layout conversions) for tests where quantization is the primary operation - Updated collect_gpu_timing_us() to accept shader_filter parameter - Updated qdq8ta_conv2d_activations to use kLayoutOnlyShaderFilter This allows tests to control what shaders are excluded from timing measurements based on what they're actually testing, while maintaining backward compatibility for all existing tests. Differential Revision: [D89832383](https://our.internmc.facebook.com/intern/diff/D89832383/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16402
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 3 New Failures, 3 Pending, 1 Unrelated FailureAs of commit 860eb6f with merge base 0dfda64 ( NEW FAILURES - The following jobs have failed:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
This PR needs a
|
mergennachin
approved these changes
Dec 29, 2025
…es via configurable shader filtering" The qdq8ta_conv2d_activations correctness tests were failing because the GPU timing collection function was filtering out quantize_and_pack_4w4c and unpack_4w4c_and_dequantize shaders from timing measurements. For these tests, these shaders ARE the operations being tested, not overhead. This change refactors shader filtering to be configurable per test case: - Added shader_filter member to TestCase class with getter/setter methods - Created kDefaultShaderFilter (filters layout conversions + quantization) for backward compatibility - Created kLayoutOnlyShaderFilter (filters only layout conversions) for tests where quantization is the primary operation - Updated collect_gpu_timing_us() to accept shader_filter parameter - Updated qdq8ta_conv2d_activations to use kLayoutOnlyShaderFilter This allows tests to control what shaders are excluded from timing measurements based on what they're actually testing, while maintaining backward compatibility for all existing tests. Differential Revision: [D89832383](https://our.internmc.facebook.com/intern/diff/D89832383/) [ghstack-poisoned]
meta-codesync
bot
merged commit 39b6ddf
into
gh/SS-JIA/387/base
161 of 166 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
The qdq8ta_conv2d_activations correctness tests were failing because the GPU timing collection function was filtering out quantize_and_pack_4w4c and unpack_4w4c_and_dequantize shaders from timing measurements. For these tests, these shaders ARE the operations being tested, not overhead.
This change refactors shader filtering to be configurable per test case:
This allows tests to control what shaders are excluded from timing measurements based on what they're actually testing, while maintaining backward compatibility for all existing tests.
Differential Revision: D89832383