split index.Tensor converter for bool vs int indexing#4123
Open
wenbingl wants to merge 1 commit intopytorch:mainfrom
Open
split index.Tensor converter for bool vs int indexing#4123wenbingl wants to merge 1 commit intopytorch:mainfrom
wenbingl wants to merge 1 commit intopytorch:mainfrom
Conversation
…ter for bool vs int indexing Add `index_has_bool_indices` validator and register two separate converters for `torch.ops.aten.index.Tensor`: - Integer indexing (HIGH priority, no output allocator): output shape is deterministic based on index tensor shape. - Boolean indexing (requires output allocator): uses nonzero() internally, producing data-dependent output shapes. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Author
|
@narendasan , please take a look whether this PR is needed, for cuda-graph. |
narendasan
reviewed
Mar 6, 2026
Collaborator
There was a problem hiding this comment.
Cool, I think this is a totally reasonable approach to WAR DDS cases. One thing that came to mind is if there is a way to make this validator generic because I think it makes sense to have "different" converters which use a the same internal defensive implementation but may have different restrictions with different codepaths like dynamic shape, dds, etc. to register multiple times and use validators to distinguish the restrictions. So a validator could take an arg index and a type allow list and deny list and pass or fail the converter @zewenli98 @apbose what do you think
Maybe a API similar to enforce_tensors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
index_has_bool_indicesvalidator and register two separate converters fortorch.ops.aten.index.Tensor:Fixes # (issue)
support cuda-graph feature for some beam search based model which failed due to output-allocator limit
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: