Skip to content

Improve type annotations for ttk.Widget #15189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
DanielOnGitHub17 wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Improve type annotations for ttk.Widget #15189

DanielOnGitHub17 wants to merge 10 commits into from
+14 −6

Conversation

@DanielOnGitHub17
Copy link

@DanielOnGitHub17 DanielOnGitHub17 commented Dec 29, 2025

This PR improves annotations for ttk.Widget

Changes.

  • Added type hints for widgetname (str | None) and kw (dict with str key) in constructor
  • Defined annotations for parameters in Widget.instate
  • Defined types for Widget.state, making statespec parameter accept a sequence or NoneType and return tuple of state strings

Suggestions

With T as a TypeVar

  • Perhaps callback in Widget.instate should be Callable[..., T]
  • And instate return type should be bool | T

@github-actions

This comment has been minimized.

Sign in to view
Akuli
Akuli reviewed Dec 29, 2025
View reviewed changes
Copy link
Collaborator

@Akuli Akuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
Akuli
Akuli reviewed Jan 1, 2026
View reviewed changes
Copy link
Collaborator

@Akuli Akuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one tweak. As usual, tkinter is more difficult than you would expect :)

@github-actions
Copy link
Contributor

github-actions bot commented Jan 1, 2026

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@DanielOnGitHub17 DanielOnGitHub17 requested a review from Akuli January 1, 2026 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Akuli Akuli Awaiting requested review from Akuli

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DanielOnGitHub17 @Akuli