[mypyc] feat: try constant fold in convert_format_expr_to_str
#20092
+10
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobTheBuidler
commented
Oct 20, 2025
| if is_str_rprimitive(node_type) or isinstance(x, StrExpr): | ||
| # NOTE: why does mypyc think our fake StrExprs are not str rprimitives? | ||
| var_str = builder.accept(x) | ||
| elif (folded := constant_fold_expr(builder, x)) is not None: |
Contributor
Author
There was a problem hiding this comment.
foldable non-string values can be easily converted to str
BobTheBuidler
commented
Oct 20, 2025
| var_str = builder.primitive_op(str_op, [builder.accept(x)], line) | ||
| elif format_op == FormatOp.INT: | ||
| if is_int_rprimitive(node_type) or is_short_int_rprimitive(node_type): | ||
| if isinstance(folded := constant_fold_expr(builder, x), int): |
Contributor
Author
There was a problem hiding this comment.
if the expr can fold as an int we can convert it to str at build time
Contributor
Author
|
These tests should start working once #19982 is merged |
This reverts commit 7345e20.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.