Update Azure AD B2C base URL to match updated endpoints#777
Merged
nijel merged 4 commits intopython-social-auth:masterfrom Mar 30, 2023
Merged
Update Azure AD B2C base URL to match updated endpoints#777nijel merged 4 commits intopython-social-auth:masterfrom
nijel merged 4 commits intopython-social-auth:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #777 +/- ##
==========================================
+ Coverage 77.34% 77.35% +0.01%
==========================================
Files 325 325
Lines 9864 9871 +7
Branches 1174 1176 +2
==========================================
+ Hits 7629 7636 +7
Misses 2084 2084
Partials 151 151
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Member
|
Merged, thanks for your contribution! |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This is similar to PR 459. I kept the policy name as an extra argument. This appears to be the default endpoint suggested by Azure AD B2C which is probably less confusing. I also made the b2clogin.com endpoint using the
authority_hostproperty. I have updated the corresponding tests as well as the docker-compose.yml to test with these Python versions: 3.6.12 3.7.16 3.8.16 3.9.16 3.10.10 3.11.2. I have documentation updates drafted and I can propose those changes if this PR is accepted.Documentation for the endpoints can be found here: https://docs.microsoft.com/en-us/azure/active-directory-b2c/b2clogin
As proposed the
base_urlwould behttps://{tenant_name}.{authority_host}/{tenant_name}.onmicrosoft.comwheretenant_nameis required butauthority_hostwill default tob2clogin.comif not set. The policy argument will still get added so an example URL for keys would look like thishttps://footenant.b2clogin.com/footenant.onmicrosoft.com/discovery/v2.0/keys?p=b2c_1_signin.Types of changes
Please check the type of change your PR introduces:
Checklist
Put an
xin the boxes that apply. You can also fill these out after creatingthe PR. If you're unsure about any of them, don't hesitate to ask. We're here to
help! This is simply a reminder of what we are going to look for before merging
your code.
Other information
SOCIAL_AUTH_AZUREAD_B2C_OAUTH2_TENANT_IDis updated toSOCIAL_AUTH_AZUREAD_B2C_OAUTH2_TENANT_NAME