Add support for flake8 per-file-ignores#28
Merged
andfoy merged 3 commits intopython-lsp:developfrom May 20, 2021
Merged
Conversation
ccordoba12
reviewed
May 2, 2021
Member
ccordoba12
left a comment
There was a problem hiding this comment.
Thanks for you contribution @brandonwillard! Looks good to me, except for some minor comments.
0f58e7c to
bc3d15e
Compare
adda517 to
aadb8a9
Compare
Contributor
Author
|
What is this |
Contributor
|
That is a flaky test that is unrelated to this PR, I've just re ran the CIs |
Contributor
|
Thanks @brandonwillard! |
|
When might this be released? I'm looking forward to using it in my editor. 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements quick and dirty support for flake8's
per-file-ignoresoption.Changes to the
list-type config parsing were necessary. Specifically, the parsing for multiline config settings, e.g.needed to be altered to allow for multiple commas on a single line, because
per-file-ignorestakes a multiline list containing file names and comma separated lists of errors to be ignored: