refactor(logging): remove unused OpenTelemetry stubs#85
Merged
Conversation
Remove fake TelemetryConfig, TelemetryManager, and all OTel config structs that were never actually integrated with real OpenTelemetry. Keep only the spans module which provides useful semantic tracing helpers that work with any tracing subscriber. - Remove TelemetryConfig, OtlpConfig, JaegerConfig, ZipkinConfig - Remove TelemetryManager with empty new()/shutdown() methods - Remove SamplingConfig, BatchProcessingConfig, propagation stubs - Update ServerConfig to remove telemetry_config field - Update McpServer to remove telemetry field and init/shutdown code - Fix span test to not depend on subscriber state
Code Coverage Report 📊Local Coverage: 22.41%
Coverage Details📋 Full Report: View on Codecov |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
PR Validation ResultsQuick Validation: ✅
Compatibility Check: ✅
Summary: ✅ All checks passed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spansmodule which provides useful semantic tracing helpersNet result: -289 lines of dead code removed
Context
Per discussion in Issue #69, the telemetry module contained placeholder code for OpenTelemetry integration that was never actually implemented. The config structs and manager were empty stubs that added complexity without value.
For local development (Claude Desktop), full OTel integration adds 141+ new crates via tonic/gRPC. Since we're focused on local work, removing these stubs simplifies the codebase without losing any functionality.
The
spansmodule is retained because it provides genuinely useful semantic tracing helpers that work with plaintracingsubscribers.Test plan
cargo check --workspacepassescargo test --workspacepasses