feat(fused): relax Pass 0 to allow balanced SP save/restore#52
Open
feat(fused): relax Pass 0 to allow balanced SP save/restore#52
Conversation
Replace has_global_writes (rejects ALL GlobalSet) with has_unsafe_global_writes, which permits the single-global save/restore pattern used by meld's stack pointer prologue/epilogue. This lets Pass 0 collapse more adapters without sacrificing provable correctness. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
has_global_writes(rejects ALLGlobalSet) withhas_unsafe_global_writes, which permits the balanced single-global save/restore pattern used by meld's stack pointer prologue/epiloguesp_save_restore_collapse_correctRocq theorem proving the relaxed predicate is safeTest plan
test_collapse_allows_sp_save_restore— balanced SP pattern collapsestest_collapse_skips_multiple_global_indices— multi-global rejectedtest_collapse_skips_write_only_global— write-only rejectedtest_collapse_skips_global_writes— existing regression guard passes🤖 Generated with Claude Code