Move 'node-addon-api' to dependencies rather than devDependencies#20
Merged
savetheclocktower merged 1 commit intomasterfrom Sep 4, 2025
Merged
Move 'node-addon-api' to dependencies rather than devDependencies#20savetheclocktower merged 1 commit intomasterfrom
savetheclocktower merged 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We published
superstringthe other day, and the publish went fine, but actually installing it doesn't work. I screwed up and leftnode-addon-apiindevDependencies— when it's actually needed for installation, since native module compilation happens as an installation task.This should fix it.
I don't think I'll wait for a review on this one; just doing it as a PR for visibility.