Bugfix: Set JSON content type when getting token#64
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Verisure login token acquisition failing with 415 Unsupported Media Type by ensuring the /auth/login request includes a JSON payload.
Changes:
- Add an explicit (empty) request body to the
/auth/logincall to avoid an empty-body request. - Document intent inline next to the request config.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
index.js
Outdated
| let authRequest = { | ||
| method: 'post', | ||
| url: '/auth/login', | ||
| data: {}, // Make sure it's content-type application/json. |
There was a problem hiding this comment.
This change is a behavioral fix for the login request (body + media type). The existing Jest/Nock tests for getToken() don't assert request body or Content-Type, so this regression could slip back in. Add/adjust a test to validate that /auth/login is called with a JSON body (e.g., {}) and Content-Type: application/json.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the problem?
When calling getToken, Verisure API responds with:
What's changed?
Pass the correct Content-Type header and valid JSON body for the request.
How can this be verified?
Tested using steps in README.
Fixes: #63