Fix GitHub Actions running in a PR by setting the correct branch#2057
Fix GitHub Actions running in a PR by setting the correct branch#2057tleonhardt wants to merge 10 commits intoprompt-toolkit:mainfrom
Conversation
The primary fix here is to change the branch name in .github/workflows/test.yaml from master to main. However a general attempt at modernizing the overall CI/CD has been made. Changes include: - Added .pre-commit-config.yaml and prek to automate checks easily - Bumped minimum Python version to 3.10 - Added support for Python 3.14, 3.15, and there free-threaded variants - Added a Makefile to make dev a little easier - Added various dependency_groups to pyproject.toml
As a library, this file shouldn't be committed
|
@jonathanslenders Hi Jonathan, thanks for creating an awesome library! The main point of this PR is to fix the GitHub Actions running in a PR - it appears to have broken at some point when the default branch was renamed from I took the liberty of providing a lot of other modernization in the process. If there is anything you don't agree with, please let me know and I'll be happy to roll that back. |
|
@jonathanslenders Thanks for all of your great feedback. I think I've addressed all of your comments so far other than deleting the But if you haven't tried it out before, I'd recommend giving the workflow a try. Prior to commits I'm accustomed to doing: make check
make docs
make testIt lets me hop back and forth between projects without having to worry about the details of how to build documentation, run tests, and do quality checks for each project. |
|
I deleted the Please let me know if there are any other changes you would like. |
|
@tleonhardt: Thanks! All looks great now! I'll have a second look tomorrow with a fresh mind right before merging. (Just want to be sure not to miss anything.) |
The primary fix here is to change the branch name in .
github/workflows/test.yamlfrommastertomain.However a general attempt at modernizing the overall CI/CD has been made.
Changes include:
.pre-commit-config.yamlandprekto automate checks easily locally via pre-commit hooksMakefileto make local development a little easierdependency_groupstopyproject.tomlCloses #2056