fix: stretch 3ds iframe height to whole device height#164
Closed
jakubjasinsky wants to merge 1 commit intomasterfrom
Closed
fix: stretch 3ds iframe height to whole device height#164jakubjasinsky wants to merge 1 commit intomasterfrom
jakubjasinsky wants to merge 1 commit intomasterfrom
Conversation
jakubjasinsky
commented
Jan 23, 2025
| // For mobile devices we want to make iframe stretch for the whole height of screen | ||
| // minus the cancel button wrapper height. This is to make sure that content of iframe | ||
| // is not cut off | ||
| const calculatedIframeHeight = |
Collaborator
Author
There was a problem hiding this comment.
This is the actual change
Collaborator
Author
|
Closing it because of this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is the first solution for fixing issue with 3DS iframe content being cropped. It stretches iframe for the whole height of the screen minus height of cancel button. Not ideal since when the iframe content is really long it will still be cropped and user will need to scroll inside. Most of the changes are formatting changes (sorry but my IDE formatted that), I will mark the actual changes with comment
CleanShot.2025-01-23.at.16.19.13.mp4
Solution
Notes
Jira Issue