This repository was archived by the owner on Jul 3, 2024. It is now read-only.
Open
Conversation
lesliecdubs
suggested changes
Jun 22, 2022
Member
lesliecdubs
left a comment
lesliecdubs
left a comment
There was a problem hiding this comment.
Hm, looks like there's a failure in the deploy preview: https://github.com/primer/presentations/runs/6997050194?check_suite_focus=true.
@siddharthkp as FR, are you able to help resolve?
janbrasna
reviewed
Feb 24, 2024
janbrasna
left a comment
janbrasna
left a comment
There was a problem hiding this comment.
The same URL is used in more places, and is now shorter:
| --- | ||
|
|
||
| Primer Presentations uses the same [color system](https://primer.style/css/support/color-system) created for our product. Color pairings for text, background, and highlighted/important information have been selected for optimal contrast. Refer to the following table for color pairings. | ||
| Primer Presentations uses the same [color system](https://primer.style/design/foundations/color) created for our product. Color pairings for text, background, and highlighted/important information have been selected for optimal contrast. Refer to the following table for color pairings. |
There was a problem hiding this comment.
FYI the URL is now https://primer.style/foundations/color …
Suggested change
| Primer Presentations uses the same [color system](https://primer.style/design/foundations/color) created for our product. Color pairings for text, background, and highlighted/important information have been selected for optimal contrast. Refer to the following table for color pairings. | |
| Primer Presentations uses the same [color system](https://primer.style/foundations/color) created for our product. Color pairings for text, background, and highlighted/important information have been selected for optimal contrast. Refer to the following table for color pairings. |
| @@ -2,7 +2,7 @@ | |||
| title: Color usage | |||
There was a problem hiding this comment.
The same URL needs fixing in more places:
https://github.com/search?q=repo%3Aprimer%2Fpresentations+color-system&type=code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I realized that this link was no longer working. I believe the new URL to correspond to the page that was linked to previously.