ssh: Specify HostKeyCallback in ClientConfig#171
Open
zimnx wants to merge 1 commit intopressly:masterfrom
Open
ssh: Specify HostKeyCallback in ClientConfig#171zimnx wants to merge 1 commit intopressly:masterfrom
zimnx wants to merge 1 commit intopressly:masterfrom
Conversation
Since golang/go#19767 SSH library requires this field on each connection. Currently all new installations of sup via `go get` doesn't work at all. This commit fixes it.
zimnx
force-pushed
the
fix-compilation
branch
from
ff129c2 to
de24929
Compare
|
Anyone going to merge this PR? |
TildeSlashC0re
approved these changes
Jan 26, 2022
TildeSlashC0re
left a comment
TildeSlashC0re
left a comment
There was a problem hiding this comment.
perfectly functional code that should have been implemented a solid while ago to ensure that people following the prominently placed install method via go get (now deprecated for go install btw) wouldn't waste their time.
Applied this rewrite of HostKeyCallback to current master branch without issues.
Please merge this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since golang/go#19767 SSH library requires this field on each connection.
Currently all new installations of sup via
go getdoesn't work at all.This commit fixes it.