- don't clobber network.Hosts map when looping over the parsed sshcon…#140
Conversation
…fig for matching hosts
| network.User = conf.User | ||
| network.IdentityFile = resolvePath(conf.IdentityFile) | ||
| network.Hosts = []string{fmt.Sprintf("%s:%d", conf.HostName, conf.Port)} | ||
| network.Hosts[k] = fmt.Sprintf("%s:%d", conf.HostName, conf.Port) |
VojtechVitek
approved these changes
May 18, 2018
Collaborator
VojtechVitek
left a comment
VojtechVitek
left a comment
There was a problem hiding this comment.
LGTM, makes sense to me
Author
|
I think I am gonna close this because there is #134 which includes this and didn't see before |
ghost
closed this
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…fig for matching hosts
Am I confused? Without this fix if the sshconfig matches even just one host then the run command is only run on that host, or it just runs on the first host the range loop gives a match, the fact that all hosts should have the same user and ssh key maybe is confusing...