dockerImage param is not required anymore for backend actions #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itories Signed-off-by: LE SAULNIER Kevin <kevin.lesaulnier.pro@gmail.com>
Signed-off-by: LE SAULNIER Kevin <kevin.lesaulnier.pro@gmail.com>
Signed-off-by: LE SAULNIER Kevin <kevin.lesaulnier.pro@gmail.com>
Signed-off-by: LE SAULNIER Kevin <kevin.lesaulnier.pro@gmail.com>
Signed-off-by: LE SAULNIER Kevin <kevin.lesaulnier.pro@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR makes the dockerImage parameter optional in GitHub Actions workflows for backend applications, enabling support for multi-module repositories where Docker image names are defined in pom.xml configuration.
Changes:
- Changed
dockerImageinput parameter from required to optional across four workflow files - Updated Docker deployment commands to conditionally use the
dockerImageparameter when provided - Modified tagging strategy in release and patch workflows to use separate tags parameter
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/release-backend-app-generic.yml | Made dockerImage optional and updated deployment to use conditional parameter substitution with separate tags |
| .github/workflows/patch-backend-app-generic.yml | Made dockerImage optional and updated deployment to use conditional parameter substitution with separate tags |
| .github/workflows/manual-dockerdeploy-backend-app-generic.yml | Made dockerImage optional and updated deployment to use conditional parameter substitution |
| .github/workflows/build-backend-app-generic.yml | Made dockerImage optional and updated deployment to use conditional parameter substitution |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: LE SAULNIER Kevin <kevin.lesaulnier.pro@gmail.com>
Signed-off-by: LE SAULNIER Kevin <kevin.lesaulnier.pro@gmail.com>
antoinebhs
approved these changes
Jan 21, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
"dockerImage" is a required param
It does not allow us to create multiple images from a multi-module repository
What is the new behavior (if this is a feature change)?
"dockerImage" is not a required param
It will use default image name from pom.xml config
We can now use those actions for multi-module repositories
Does this PR introduce a breaking change or deprecate an API?