Refactor tests for startBatch() -> createWriter()#549
Merged
Conversation
🦋 Changeset detectedLatest commit: 23c4238 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rkistner
changed the title
stevensJourney
previously approved these changes
Mar 10, 2026
Collaborator
stevensJourney
left a comment
stevensJourney
left a comment
There was a problem hiding this comment.
I like this new addition. Happy with the changes.
modules/module-mongodb-storage/src/storage/implementation/MongoBucketBatch.ts
Show resolved
Hide resolved
stevensJourney
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ports a refactoring from #468:
startBatch()using a callback withcreateWriter()as an AsyncDisposable.await resolveTestTable(writer), which will eventually return a real SourceTable instead of a mocked one.This does not remove the internal usage of
startBatch()yet - it mostly focuses on the test refactor. The internal usage ofstartBatch()can be tackled next.The main goal is to reduce the diff size and potential for merge conflicts from #468.