Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses posit-dev/positron#8450
Set our options after the user R profiles have been sourced, and only if the options haven't been set by the user already. We detect user overrides in one of two ways:
If R sets the option to a non-null value by default, we require the user to wrap the option in
AsIs, which we take as a sign it was overridden in the Rprofile.For all other options, if we see a non-null value it means it was overridden.
I've taken the opportunity to consolidate all options settings in one place (the lazily invoked init function), and document our overrides in
doc/configuration.md.To launch Shiny applications in the system browser you need the following configuration:
An alternative to this approach is to recommend using the new hook that @jennybc is implementing in #1088. The approach implemented in this PR has the advantage that the user configuration also works in the R cli without any duplication.