Skip to content

Conversation

@marcellodebernardi
Copy link
Contributor

This PR makes a few miscellaneous tweaks and fixes that were missed in the 1.0.0 rewrite (see #161). Namely:

  1. Add support for Makefile.local
  2. Fix the version bound on pyspark (too loose, resulted in a regression when the version got upgraded)
  3. An error in the logging configuration

Copilot AI review requested due to automatic review settings February 9, 2026 15:39
@greptile-apps
Copy link

greptile-apps bot commented Feb 9, 2026

Greptile Overview

Greptile Summary

This PR addresses three miscellaneous issues from the 1.0.0 rewrite: adds Makefile.local support for local development overrides, fixes the logging configuration to use the correct package name (plexe instead of source), and tightens the pyspark version bound to prevent regressions.

  • Added Makefile.local to .gitignore and included it in the Makefile for local development customization
  • Fixed logger name in plexe/config.py:497 from source to plexe to match the package name (all other modules use __name__ which correctly inherits from this root logger)
  • Tightened pyspark version constraint from >=4.0.1,<5.0.0 to >=4.0.1,<4.1.0 in both pyproject.toml and Dockerfile to prevent issues with 4.1.x versions
  • Bumped package version to 1.0.1 as a patch release

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • All changes are straightforward bug fixes and configuration improvements. The logging fix corrects an obvious error (wrong package name), the pyspark version constraint prevents known regressions, and the Makefile.local support is a standard development practice that's properly gitignored.
  • No files require special attention

Important Files Changed

Filename Overview
Dockerfile Tightened pyspark version bound from <5.0.0 to <4.1.0 to prevent regression
Makefile Added -include Makefile.local to support uncommitted local overrides
plexe/config.py Fixed logger name from source to plexe to match package name
pyproject.toml Bumped version to 1.0.1 and tightened pyspark bound to <4.1.0

@marcellodebernardi marcellodebernardi merged commit eb83b65 into main Feb 9, 2026
13 checks passed
@marcellodebernardi marcellodebernardi deleted the fix/miscellaneous-rewrite-errors branch February 9, 2026 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant