-
Notifications
You must be signed in to change notification settings - Fork 8k
Remove unused mysqlnd options #20979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Remove unused mysqlnd options #20979
Conversation
bukka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should be dropping those even though they are not used right now.
Ok, but is there a good reason to keep them? We cannot document them in the PHP manual because they don't do anything and it's unlikely that they will ever be reused in the future. |
Why? Having a non-existing implementation is completely useless, and on top of that if someone wants to add missing protocol functionality they are going to assume that all the existing options are actually implemented. Moreover, this has no impact on PHP userland as you cannot "directly" access MySQLnd drivers data AFAIK. |
6203275 to
6116737
Compare
|
I understand what it is. I just don't think we need to remove bits that can be potentially useful. They are just definitions for potential later use. So I just don't see reason to remove it. But I don't really feel strongly about this so don't take it as a blocker for merging. |
MYSQL_OPT_WRITE_TIMEOUTwas a noop as this was never implemented.The protocol options were introduced in ebaee8a and it's unclear if they ever were used or what they were meant for.