ext/random: mark rand() as an alias of mt_rand() #20796
Open
+8
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
requested review from
TimWolla,
kocsismate and
zeriyoshi
as code owners
alexandre-daubois
approved these changes
Dec 29, 2025
TimWolla
requested changes
Dec 29, 2025
Member
TimWolla
left a comment
TimWolla
left a comment
There was a problem hiding this comment.
They are not equivalent. rand() accepts the parameters in reverse order: https://3v4l.org/OpGqW
This is also documented in https://www.php.net/manual/en/function.rand.php
Note: As of PHP 7.1.0, rand() uses the same random number generator as mt_rand(). To preserve backwards compatibility rand() allows max to be smaller than min as opposed to returning false as mt_rand().
TimWolla
reviewed
Dec 29, 2025
|
|
||
| function mt_rand(int $min = UNKNOWN, int $max = UNKNOWN): int {} | ||
|
|
||
| /* @alias mt_rand */ |
Member
There was a problem hiding this comment.
This is also not a proper docblock (missing asterisk). I don't think this had an effect based on the arginfo diff, otherwise CI should hopefully have caught it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As all the other rand like functions are marked as aliases of the
mt_*variants.