Skip to content
This repository was archived by the owner on Jun 21, 2022. It is now read-only.

Conversation

@AlekSi
Copy link
Contributor

@AlekSi AlekSi commented Feb 3, 2021

PMM-5194


  • Tests passed.
  • Feature build pass.
  • (Re)requested review.
  • Fix conflicts with target branch.
  • Update API dependency.
  • Update jira ticket description if needed.
  • Attach screenshots/console output to confirm new behavior to jira ticket, if applicable.

@AlekSi AlekSi self-assigned this Feb 3, 2021
@codecov
Copy link

codecov bot commented Feb 3, 2021

Codecov Report

Merging #643 (846ce69) into PMM-2.0 (0f501d3) will increase coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           PMM-2.0     #643      +/-   ##
===========================================
+ Coverage    49.26%   49.42%   +0.15%     
===========================================
  Files          128      123       -5     
  Lines        16453    15722     -731     
===========================================
- Hits          8105     7770     -335     
+ Misses        7603     7235     -368     
+ Partials       745      717      -28     
Flag Coverage Δ
all 48.84% <ø> (+0.13%) ⬆️
cover 49.39% <ø> (+0.12%) ⬆️
crosscover 49.42% <ø> (+0.15%) ⬆️
update 16.72% <ø> (+0.58%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
services/agents/channel/channel.go 73.85% <ø> (-1.76%) ⬇️
services/management/ia/alerts_service.go 0.00% <0.00%> (-16.28%) ⬇️
services/agents/postgresql.go 72.00% <0.00%> (-1.08%) ⬇️
services/converters.go 71.20% <0.00%> (-0.99%) ⬇️
services/agents/mongodb.go 73.21% <0.00%> (-0.93%) ⬇️
services/victoriametrics/scrape_configs.go 82.42% <0.00%> (-0.75%) ⬇️
services/management/ia/rules_service.go 46.75% <0.00%> (-0.70%) ⬇️
services/agents/proxysql.go 90.00% <0.00%> (-0.63%) ⬇️
models/template_helpers.go 55.15% <0.00%> (-0.48%) ⬇️
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f501d3...a98489a. Read the comment docs.


//go:generate reform

type TunnelType string

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci-lint] reported by reviewdog 🐶
exported type TunnelType should have comment or be unexported (golint)

type TunnelType string

const (
ConnectTunnelType TunnelType = "connect"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci-lint] reported by reviewdog 🐶
exported const ConnectTunnelType should have comment (or a comment on this block) or be unexported (golint)

ListenTunnelType TunnelType = "listen"
)

//reform:tunnels

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci-lint] reported by reviewdog 🐶
comment on exported type Tunnel should be of the form "Tunnel ..." (with optional leading article) (golint)


const (
ConnectTunnelType TunnelType = "connect"
ListenTunnelType TunnelType = "listen"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci-lint] reported by reviewdog 🐶
const ListenTunnelType is unused (unused)

AlekSi and others added 12 commits February 5, 2021 18:54
# Conflicts:
#	Gopkg.lock
#	services/agents/channel/metrics.go
#	services/agents/registry.go
# Conflicts:
#	Gopkg.lock
#	vendor/github.com/percona/pmm/api/agentpb/agent.pb.go
@AlekSi AlekSi removed their assignment Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants