Prepare try-runtime-cli for publication on crates.io
#120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rockbmb
added
enhancement
`--dev` implies it.
... in `follow_chain.rs` test, and also increase waiting time for node's warm-up.
rockbmb
force-pushed
the
crates-publishing-cleanup
branch
from
afb983d to
873bdea
Compare
These tests used `assert_cmd::carg::cargo_bin`, which is deprecated. It is meant to be replaced with the macro `assert_cmd::cargo_bin!`, which required tests to be moved to the `cli` crate. If tests hadn't been moved, that macro would fail to find the binary, as the `CARGO_BIN_EXE_*` environment variable with the absolute path to a binary target’s executable would not have been set. Moving the tests causes it to be set, and the macro then works. See https://doc.rust-lang.org/beta/cargo/reference/environment-variables.html
The previous commit added a `dev-dependencies` section to the root `Cargo.toml`, which is not allowed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #93 .
This issue will perform the necessary changes to
try-runtime-clito publish it on crates.io.@ggwpez will ping you when it's time for the last step.