Add script to provide team velocity#404
Conversation
by calculating the weekly numbers of closed issues. Signed-off-by: Frantisek Lachman <flachman@redhat.com>
lachmanfrantisek
force-pushed
the
team-velocity-script
branch
from
086df5d to
2890b7b
Compare
lbarcziova
left a comment
lbarcziova
left a comment
There was a problem hiding this comment.
thanks, nicely done! Do you plan to add some README e.g. also mentioning what would be the values for the labels that we will use? (I was also a little bit surprised by the location of the script)
| issue_labels = [label.name for label in issue.labels] | ||
| value: Optional[int] = None | ||
| for label_name, label_value in labels: | ||
| if label_name in issue_labels: | ||
| value = label_value | ||
|
|
||
| if value is not None: | ||
| return value |
There was a problem hiding this comment.
so this should work as Later definition has priority right? Maybe it would also make sense to always get the max value?
There was a problem hiding this comment.
so this should work as Later definition has priority right?
Yes, but max might be a better idea.
| return week_numbers | ||
|
|
||
|
|
||
| DEFAULT_PROJECTS = [ |
There was a problem hiding this comment.
I am wondering if we could make this dynamically evaluated as well..
There was a problem hiding this comment.
I was thinking about that but we don't have this in OGR and not easily via pygithub as well... I'd leave this for later.
I would wait for a while to agree on "our" definition and will add it there. I agree it does not fit into this repo completely but better than elsewhere..;) |
3 participants
by calculating the weekly numbers of closed issues.