I don't want no scrubs (for read-only Crucible backends) #1028
+12
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Propolis should not launch scrubs when constructing a Crucible backend for a read-only disk. Because the Crucible volume itself is read-only, the scrub will never succeed, so we shouldn't waste time attempting it. This commit changes the `CrucibleBackend` to skip launching scrubs if the backend is readonly.
jmpesp
approved these changes
Jan 29, 2026
leftwo
approved these changes
Jan 30, 2026
| // | ||
| // We should not scrub read-only volumes, as we cannot write back to | ||
| // them, due to...you know, being read-only. So just don't do that. | ||
| if !opts.is_read_only() && volume.has_read_only_parent() { |
Contributor
There was a problem hiding this comment.
I'm not convinced Nexus can construct a read only volume with a read_only_parent, but I suppose nothing stops you from sending propolis a toml directly that contains such a beast. So, it's probably best to just prevent it.
Member
Author
There was a problem hiding this comment.
@jmpesp told me it was possible, though I'm not sure if it will currently happen for the way we construct ro disks or not?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propolis should not launch scrubs when constructing a Crucible backend for a read-only disk. Because the Crucible volume itself is read-only, the scrub will never succeed, so we shouldn't waste time attempting it.
This commit changes the
CrucibleBackendto skip launching scrubs if the backend is readonly.