AO3-6067 Uncategorized fandoms in collections not showing #5514
Conversation
The new fandom method actually would return any fandom, even possible copy of fandom already in fandom_ids
|
I'd like to add a test to make sure that non-canonical fandoms don't get double counted. How exactly do I set up a non-canonical fandom under a canonical fandom in cucumber? After this is done, I shall remove put this as ready for review |
simplified check to know if a fandom is not categorized Co-authored-by: ömer faruk <b585j@transformativeworks.org>
app/controllers/tags_controller.rb
Outdated
| @bookmarks = @tag.bookmarks.visible.paginate(page: params[:page]) | ||
| @collections = @tag.collections.paginate(page: params[:page]) |
There was a problem hiding this comment.
This way on the unwrangled tag's collection page it's showing all the bookmarks with that tag, regardless if they're in the collection or not, just works is fine. Can you also add tests to at least one of them since they're not on the manual tests too?
There was a problem hiding this comment.
Should all bookmarks and collections be visible then?
There was a problem hiding this comment.
I think none of them should, it'd be a bit confusing to the user otherwise
There was a problem hiding this comment.
Alrighty. I shall modify this and add a test to cover this behaviour
|
Hmm, I seem to not be able to locally replicate the issue with the latest automated testing |
2 participants
Issue
https://otwarchive.atlassian.net/browse/AO3-6067
Purpose
This makes uncategorized fandoms be listed on collection fandoms page. As a bonus, this also makes the unwrangled tags collection page show only the work in the collection. This modifies the method used to fetch the fandom (being a combination of how it used to work with the fandom_ids field, and how view works, by going through the fandom tags on the work).
Credit
Danaël / Rever ( they / he )
Danaël Villeneuve on jira