Skip to content

[FSSDK-11953] java-sdk CMAB: Fix missing bucketing reasons in CMAB decision path #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[FSSDK-11953] java-sdk CMAB: Fix missing bucketing reasons in CMAB decision path #592

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5c41b97
Initial plan
Copilot Dec 3, 2025
97d6538
Fix missing CMAB bucketing reasons in decision process
Copilot Dec 3, 2025
6d0ccc1
Merge branch 'master' into copilot/check-for-pr-errors
Mat001 Dec 18, 2025
2fc5ec5
fix: missing decision reasons added in cmab flow
FarhanAnjum-opti Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core-api/src/main/java/com/optimizely/ab/bucketing/DecisionService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,9 +171,10 @@ public DecisionResponse<Variation> getVariation(@Nonnull Experiment experiment,
String bucketingId = getBucketingId(user.getUserId(), user.getAttributes());
String cmabUuid = null;
decisionVariation = bucketer.bucket(experiment, bucketingId, projectConfig, decisionPath);
reasons.merge(decisionVariation.getReasons());
if (decisionPath == DecisionPath.WITH_CMAB && isCmabExperiment(experiment) && decisionVariation.getResult() != null) {
// group-allocation and traffic-allocation checking passed for cmab
// we need server decision overruling local bucketing for cmab
// we need server decision overruling local bucketing for cmab
DecisionResponse<CmabDecision> cmabDecision = getDecisionForCmabExperiment(projectConfig, experiment, user, bucketingId, options);
reasons.merge(cmabDecision.getReasons());

Expand All @@ -189,7 +190,6 @@ public DecisionResponse<Variation> getVariation(@Nonnull Experiment experiment,
}
} else {
// Standard bucketing for non-CMAB experiments
reasons.merge(decisionVariation.getReasons());
variation = decisionVariation.getResult();
}

Expand Down