Fix: Added customizable ansibleEE env ConfigMap name #1772
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: oliashish The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d91bb4d5006d46cb8f53bf9db1e962da ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 12m 34s |
Currently there is only one hardcoded string `openstack-aee-default-env` for ansibleEE environment variable, which is applied throughout the cluser. This PR tries to let users ability to customize the ansibleEE env configMap for deployments and nodeset levels individually. The precedence order for ansibleEEEnvConfigMap is deployment > nodeset > default.
oliashish
force-pushed
the
fix/configurable-envConfigMapName
branch
from
b1bf4a9 to
0822da4
Compare
oliashish
changed the title
| if envConfigMapName == "" { | ||
| envConfigMapName = "openstack-aee-default-env" | ||
| } | ||
|
|
There was a problem hiding this comment.
Can we verify if this block is okay for backward compatibility? Or is there a better way to approach this?
|
@oliashish: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Currently there is only one hardcoded string
openstack-aee-default-envfor ansibleEE environment variable, which is applied throughout the cluser.This PR tries to let users ability to customize the ansibleEE env configMap for deployments and nodeset levels individually. The precedence order for ansibleEEEnvConfigMap is deployment > nodeset > default.
Test Cases
Jira: OSPRH-18955