Skip to content
This repository was archived by the owner on Aug 29, 2018. It is now read-only.

Bug 1244126: Allowing 4096 char limit for env variable values#6446

Open
abhgupta wants to merge 1 commit intoopenshift:masterfrom
abhgupta:abhgupta-dev
Open

Bug 1244126: Allowing 4096 char limit for env variable values#6446
abhgupta wants to merge 1 commit intoopenshift:masterfrom
abhgupta:abhgupta-dev

Conversation

@abhgupta
Copy link
Member

@thrasher-redhat @tiwillia PTAL

Fixes Bug 1244126

@tiwillia
Copy link
Member

Do we want to update the nodes with the new default limit? Otherwise the api will pass validation, but unless the allowed size has been increased on the node, the environment variable will fail to be created. I don't think we have a value set up in node.conf for the maximum to be changed easily:

https://github.com/openshift/origin-server/blob/master/node/lib/openshift-origin-node/model/application_container_ext/environment.rb#L14

This node test also needs to be updated if we increase the default:

https://github.com/openshift/origin-server/blob/master/node/test/unit/application_container_test.rb#L366

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants