This repository was archived by the owner on Aug 29, 2018. It is now read-only.
Bug 1244126: Allowing 4096 char limit for env variable values#6446
Open
abhgupta wants to merge 1 commit intoopenshift:masterfrom
Open
Bug 1244126: Allowing 4096 char limit for env variable values#6446abhgupta wants to merge 1 commit intoopenshift:masterfrom
abhgupta wants to merge 1 commit intoopenshift:masterfrom
Conversation
Member
|
Do we want to update the nodes with the new default limit? Otherwise the api will pass validation, but unless the allowed size has been increased on the node, the environment variable will fail to be created. I don't think we have a value set up in node.conf for the maximum to be changed easily: This node test also needs to be updated if we increase the default: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@thrasher-redhat @tiwillia PTAL
Fixes Bug 1244126