Added generic call script custom DNS Plugin Gem#6119
Added generic call script custom DNS Plugin Gem#6119grahamnscp wants to merge 1 commit intoopenshift:masterfrom
Conversation
|
@sosiouxme Review please. |
|
@grahamrht The concept is good, the implementation looks good at first glance, but it will have to be added to my list to review fully after a few other things are done. Sorry for the wait, thanks for getting this moving! |
|
Thanks Luke, Best regards, On 11/06/2015 11:44, Luke Meyer wrote:
Graham Hares, RHCA |
There was a problem hiding this comment.
Should these parameters be read in from a configuration file? Few actual openshift environments have named installed on the same host as a broker, so this plugin won't work for most.
They should either be read in from a configuration file or passed into the script as parameters. Normally, dns plugins establish connection information in the plugin class's initialize method. I can see why that wasn't done here, since it would be cumbersome to pass the connection information every time the script is called. If the connection information isn't passed as parameters, they should at least be read in from a configuration file.
One issue with defining the connection parameters in this script is that this file is not marked as a configuration file in the rpm spec. If a newer version of the rpm is installed, it will overwrite the modified file with the one in the newer rpm.
|
@grahamrht the Other than that and the few line notes I made, this looks good to me. |
4 participants
Hi guys, created a useful generic DNS plugin that calls a script specified in the config file. An example script that calls nsupdate is included in the conf directory too.
Creating a plugin was not well documented so also serves as an example as well as allowing a free form script to wrap any custom DNS deployment requirements.
Hope that it would be a useful addition to the upstream project, also my first upstream pull request :)
Best regards, Graham