[release-4.18] OCPBUGS-76582: Fix Cinder, Manila driver metrics #501
Conversation
We had configured the proxy sidecar container for the driver in the
controller Deployment, but the upstream it was pointing to did not
exist. Fix this by setting the --http-endpoint option. Per the upstream
docs [1]:
--http-endpoint <HTTP server>
This argument is optional.
The TCP network address where the HTTP server for providing metrics
for diagnostics, will listen (example: `:8080`).
The default is empty string, which means the server is disabled.
There's a bit of cleanup needed here to avoid hardcoding something which
is generated (via a loop-variable) elsewhere, but we'll do that
separately.
[1] https://github.com/kubernetes/cloud-provider-openstack/blob/release-1.32/docs/cinder-csi-plugin/using-cinder-csi-plugin.md#command-line-arguments
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
The openstack-manila driver does not currently support this. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
|
/verified later @stephenfin Assuming CI is good. |
|
/retest-required |
|
/retitle [release-4.18] OCPBUGS-76582: Fix Cinder, Manila driver metrics |
openshift-ci
bot
changed the title
openshift-ci-robot
added
jira/valid-reference
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-76582, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@stephenfin: This pull request references Jira Issue OCPBUGS-76582, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@stephenfin: This pull request references Jira Issue OCPBUGS-76582, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (imatza@redhat.com), skipping review request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
mandre
left a comment
mandre
left a comment
There was a problem hiding this comment.
/lgtm
/approve
/label backport-risk-assessed
|
@mandre: Can not set label backport-risk-assessed: Must be member in one of these teams: [openshift-patch-managers openshift-release-oversight openshift-staff-engineers openshift-sustaining-engineers] DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mandre, openshift-cherrypick-robot, stephenfin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/test e2e-openstack |
|
@openshift-cherrypick-robot: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
8 participants
This is an automated cherry-pick of #386
/assign stephenfin