TRT-2511:Reapply "OTA-1604: migrate ocp-46922 from otp to cvo repo" #1301
Conversation
WalkthroughThis change adds a new test for cluster-version-operator that validates correct runlevel and security context configuration. It includes a JSON test payload entry, a new CVO integration test, and utility helper functions for environment detection and Kubernetes client initialization. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes ✨ Finishing touches
Comment |
jiajliu
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@jiajliu: This pull request references TRT-251 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@test/cvo/cvo.go`:
- Around line 72-82: Update the redundant wording "openshift.io/scc annotation"
to "openshift.io/scc" in the test that inspects the CVO pod: change the
human-readable description string passed to By(...) and the
Expect(...).To(Equal(...)) failure message so they reference "openshift.io/scc"
(use cvoPod.Name and sccAnnotation as already referenced) instead of the
duplicated "annotation" word; ensure the strings around the annotation key are
updated where cvoPod and sccAnnotation are used.
|
@jiajliu: This pull request references TRT-2511 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@jiajliu: This pull request references TRT-2511 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/payload-job periodic-ci-openshift-microshift-release-4.22-periodics-e2e-aws-ovn-ocp-conformance |
|
@jiajliu: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/988df7e0-f5d7-11f0-87ee-a25503e630b6-0 |
|
Test pass on standard OCP: Test skip on Microshift: /verified by @jiajliu cc @hongkailiu to review, thanks. |
openshift-merge-robot
added
the
needs-rebase
This reverts commit 278da7b.
openshift-merge-robot
removed
the
needs-rebase
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@test/cvo/cvo.go`:
- Around line 56-60: The test currently calls SkipIfHypershift(ctx, restCfg) but
misses skipping MicroShift; add a call to SkipIfMicroshift(ctx, restCfg) right
after the SkipIfHypershift invocation, capture its returned error into err2 (or
reuse err) and assert o.Expect(err2).NotTo(o.HaveOccurred(), "Failed to
determine if cluster is MicroShift") so the test exits on MicroShift clusters
before proceeding with CVO checks; ensure you call the same context/restCfg
variables and keep the existing HyperShift skip intact.
|
@jiajliu: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Summary of changes from the last test:
Retest result on Microshift: Retest results on standard OCP: @hongkailiu Thank you for the review, PTAL again. |
|
/verified by @jiajliu |
openshift-ci-robot
added
the
verified
|
@jiajliu: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hongkailiu, jiajliu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
4 participants
IsHypershift, to fix the potential issue like microshift failureSkipIfMicroshiftto skip tests when running on a microshift.