Skip to content

Conversation

@openshift-cherrypick-robot

This is an automated cherry-pick of #1257

/assign wking

When a pod spec is being ensured, hostUsers flag is not taken into
account. This is now fixed and hostUsers is copied into the resulting
pod spec.
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-64732 has been cloned as Jira Issue OCPBUGS-64828. Will retitle bug to link to clone.
/retitle [release-4.20] OCPBUGS-64828: lib/resourcemerge: Add support for hostUsers flag

Details

In response to this:

This is an automated cherry-pick of #1257

/assign wking

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.20] OCPBUGS-64732: lib/resourcemerge: Add support for hostUsers flag [release-4.20] OCPBUGS-64828: lib/resourcemerge: Add support for hostUsers flag Nov 7, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 7, 2025
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-64828, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #1257

/assign wking

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Member

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/jira refresh
/label backport-risk-assessed

@openshift-ci openshift-ci bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. lgtm Indicates that a PR is ready to be merged. labels Nov 7, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2025
@wking
Copy link
Member

wking commented Nov 10, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 10, 2025
@openshift-ci-robot
Copy link
Contributor

@wking: This pull request references Jira Issue OCPBUGS-64828, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.z) matches configured target version for branch (4.20.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-64732 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-64732 targets the "4.21.0" version, which is one of the valid target versions: 4.21.0
  • bug has dependents

Requesting review from QA contact:
/cc @jiajliu

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from jiajliu November 10, 2025 17:50
@jiajliu
Copy link
Contributor

jiajliu commented Jan 29, 2026

/payload-job-with-prs release-openshift-origin-installer-launch-aws-modern openshift/cluster-openshift-controller-manager-operator#406

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 29, 2026

@jiajliu: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

@jiajliu
Copy link
Contributor

jiajliu commented Jan 29, 2026

/payload-job-with-prs pull-ci-openshift-origin-release-4.20-e2e-aws-ovn openshift/cluster-openshift-controller-manager-operator#406

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 29, 2026

@jiajliu: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

@jiajliu
Copy link
Contributor

jiajliu commented Jan 29, 2026

/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.20-e2e-aws-ovn openshift/cluster-openshift-controller-manager-operator#406

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 29, 2026

@jiajliu: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

@jiajliu
Copy link
Contributor

jiajliu commented Jan 29, 2026

/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn openshift/cluster-openshift-controller-manager-operator#406

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 29, 2026

@jiajliu: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

@jiajliu
Copy link
Contributor

jiajliu commented Jan 29, 2026

/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn openshift/cluster-openshift-controller-manager-operator#406

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 29, 2026

@jiajliu: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c4fedc90-fcc1-11f0-9e92-f77259178301-0

@jiajliu
Copy link
Contributor

jiajliu commented Jan 29, 2026

  1. No actual pod specs with hostUsers found in the 4.20.12 manifests(the latest 4.20.z)
# grep -r "hostUsers: " 4.20-manifest/
4.20-manifest/0000_20_kube-apiserver-operator_00_scc-nested-container.yaml:      use a user namespace ("hostUsers: false"), their actual UID/GID on the host
  1. Opened a test pr to cherrypick CNTRLPLANE-1544: Use user namespace for the operator cluster-openshift-controller-manager-operator#397 into 4.20
  2. Triggered test with the two prs, but installation failed due to the new changes.
...
level=error msg=The 'wait-for install-complete' subcommand can then be used to continue the installation
level=error msg=failed to initialize the cluster: Multiple errors are preventing progress:
level=error msg=* Cluster operator openshift-controller-manager is not available
level=error msg=* Could not update role "openshift-controller-manager/prometheus-k8s" (951 of 959): resource may have been deleted: timed out waiting for the condition
Installer exit with code 6
  1. Checked the log and found it should be related with CNTRLPLANE-1544: scc: restricted-v3: Fix runAsUser range cluster-kube-apiserver-operator#1947 which has not yet backported to 4.20 yet.
  2. Re-tested and passed with above three prs(refer to https://prow.ci.openshift.org/view/gs/test-platform-results/logs/release-openshift-origin-installer-launch-aws-modern/2016760779402907648)

pre-merge test pass.

/verified by @jiajliu

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jan 29, 2026
@openshift-ci-robot
Copy link
Contributor

@jiajliu: This PR has been marked as verified by @jiajliu.

Details

In response to this:

  1. No actual pod specs with hostUsers found in the 4.20.12 manifests(the latest 4.20.z)
# grep -r "hostUsers: " 4.20-manifest/
4.20-manifest/0000_20_kube-apiserver-operator_00_scc-nested-container.yaml:      use a user namespace ("hostUsers: false"), their actual UID/GID on the host
  1. Opened a test pr to cherrypick CNTRLPLANE-1544: Use user namespace for the operator cluster-openshift-controller-manager-operator#397 into 4.20
  2. Triggered test with the two prs, but installation failed due to the new changes.
...
level=error msg=The 'wait-for install-complete' subcommand can then be used to continue the installation
level=error msg=failed to initialize the cluster: Multiple errors are preventing progress:
level=error msg=* Cluster operator openshift-controller-manager is not available
level=error msg=* Could not update role "openshift-controller-manager/prometheus-k8s" (951 of 959): resource may have been deleted: timed out waiting for the condition
Installer exit with code 6
  1. Checked the log and found it should be related with CNTRLPLANE-1544: scc: restricted-v3: Fix runAsUser range cluster-kube-apiserver-operator#1947 which has not yet backported to 4.20 yet.
  2. Re-tested and passed with above three prs(refer to https://prow.ci.openshift.org/view/gs/test-platform-results/logs/release-openshift-origin-installer-launch-aws-modern/2016760779402907648)

pre-merge test pass.

/verified by @jiajliu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link

coderabbitai bot commented Jan 29, 2026

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 73583cd and 2 for PR HEAD de26bdb in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 29, 2026

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 3ef3dcb into openshift:release-4.20 Jan 29, 2026
17 checks passed
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue Verification Checks: Jira Issue OCPBUGS-64828
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-64828 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

This is an automated cherry-pick of #1257

/assign wking

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants