CNTRLPLANE-2620: propagate global tls config to operand#407
CNTRLPLANE-2620: propagate global tls config to operand#407ricardomaraschini wants to merge 3 commits intoopenshift:masterfrom
Conversation
bump library-go so we can use the default tls sync controller.
observe the global apiserver tls config and propagates it to the operand in case of changes. this seems to affect only liveness and readiness probes in the operand. nonetheless getting this done will avoid a "false" positive later on if (tls-scanner may flag this as an issue).
|
@ricardomaraschini: This pull request references CNTRLPLANE-2620 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@ricardomaraschini: This pull request references CNTRLPLANE-2620 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ricardomaraschini The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
TLS config injected: |
|
Faulty CI does not seem to be related to the change. /retest |
|
@ricardomaraschini: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Observe the global apiserver tls config and propagates it to the operand in case of changes. this seems to affect only liveness and readiness probes in the operand. nonetheless getting this done will avoid a false positive later on if (tls-scanner may flag this as an issue).
This is mostly vendoring.