Merged
Conversation
commit: |
james-elicx
force-pushed
the
j-branch-6
branch
3 times, most recently
from
ddc3099 to
594b928
Compare
james-elicx
force-pushed
the
j-branch-6
branch
from
594b928 to
03cc85e
Compare
Closed
vicb
reviewed
Feb 1, 2026
| @@ -0,0 +1,91 @@ | |||
| { | |||
Collaborator
Author
There was a problem hiding this comment.
yeah, we have vscode settings in the repo, so i added the zed ones for oxc since i use zed
vicb
reviewed
Feb 1, 2026
vicb
reviewed
Feb 1, 2026
| import type { OpenNextHandlerOptions } from "types/overrides"; | ||
| import { runWithOpenNextRequestContext } from "utils/promise"; | ||
|
|
||
| import type { OpenNextNodeResponse } from "@/http/index.js"; |
Contributor
There was a problem hiding this comment.
@/http looks weird (not consistent).
IIUC you plan to address it in a follow up which is reasonable
Collaborator
Author
There was a problem hiding this comment.
yeah would have been a bigger diff if i addressed them all in one, wanted to keep it smaller. going to tidy it up tomorrow evening
vicb
approved these changes
Feb 1, 2026
Contributor
vicb
left a comment
vicb
left a comment
There was a problem hiding this comment.
LGTM with a few nits, thanks James!
Bump engines version for Node to 20
20 EOL in 2026-04, what about 22?
Collaborator
Author
Oh wow, that really crept up, didn't realise it was so soon, I'll up it to 22 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notable changes
httpimport alias to@/httpfor aws to avoid node builtin clashes (one of the linting rules that now applies throughout).Result