-
Notifications
You must be signed in to change notification settings - Fork 8
Remove undefined terms in parameterGroup examples #204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Hi @chris-little, thanks for doing this. Having thought about it, I'm wondering if we should just remove the section about statistical measures altogether for now. There's a lot of stuff that would need defining, even in the new simplified version. How about simply including some placeholder text, e.g. "ParameterGroups can also be used to gather related statistical quantities, but this will be defined in a future version of the spec"? |
|
This looks OK as far as I can tell but would benefit from a review from someone who's more familiar with how to insert new vocabularies via the JSON-LD context - perhaps @KathiSchleidt? |
link to archived version of UncertML website (closed in 2016)
Reliable reference for statistical Measures found
|
I'm fine with the hack of referencing eurostat glossary terms, but don't understand why you removed the |
| In this example, additional semantics for the registered `dct` prefix are provided by stating that the `"dct:license"` member value in this document is an identifier and not just an unstructured string. | ||
| Example: | ||
|
|
||
| In this example, extra attributes of the `Parameter` have been declared stating that the parameter is a more specific example in the context of a more general vocabulary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please replace the 2nd instance of the word "example" with concept, the example in the example is confusing:
"parameter is a more specific concept in the context of a more general vocabulary."
| "@context": [ | ||
| "https://covjson.org/context.jsonld", | ||
| { | ||
| "skos": "http://www.w3.org/2004/02/skos/core", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "label" : { | ||
| "en": "Sea surface temperature daily mean" | ||
| }, | ||
| "statisticalMeasure": "https://web.archive.org/web/20161029215223/http://uncertml.org/statistics/mean", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the example above, statisticalMeasure should reference https://ec.europa.eu/eurostat/statistics-explained/index.php?title=Glossary:Arithmetic_mean
|
On
I left various comments in the file |
|
@KathiSchleidt > I'm fine with the hack of referencing eurostat glossary terms, but don't understand why you removed the The PR was to remove undefined terms in response to your Issue #194 . It is only an example. It is not normative. Do you have a reliable source definition of |
Removed undefined terms
narrowerThan,statisticalMeasureandstatisticalPeriodfrom the Parameter Group examples. Add another example to the JSON-LD section.