-
Notifications
You must be signed in to change notification settings - Fork 4.2k
fix: bump learning-core to 0.30.2 [ulmo] #37730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bump learning-core to 0.30.2 [ulmo] #37730
Conversation
|
Thanks for the pull request, @dwong2708! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
640e39a to
e7c77fd
Compare
| # See issue https://github.com/openedx/public-engineering/issues/440 for details regarding the ongoing fix. | ||
| # The constraint can be removed once a release (pip-tools > 7.5.1) is available with support for pip 25.3 | ||
| # Issue to track this dependency and unpin later on: https://github.com/openedx/edx-lint/issues/503 | ||
| pip<25.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not seem like something that should come as part of this backport.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same issue as here: #37729 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed this code to keep only the bump changes, but I noticed the CI is failing due to the requirements. Do I need to run make compile-requirements to fix it? I ran it earlier, and it removed this code from the file. @ormsbee
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dwong2708: I guess so. Yes, please run make compile-requirements and see what happens. Thank you.
e7c77fd to
88347b5
Compare
6d2b7a0 to
be58286
Compare
be58286 to
cd8b532
Compare
cd8b532 to
6d363af
Compare
|
@dwong2708: I'm trying another PR with |
Looks like we need to wait for this fix #37797 |
|
FYI, the backport of that PR is here: #37799 |
6d363af to
057f973
Compare
Backport of #37729
This pulls in backup and restore changes from:
openedx/openedx-learning#448
It involves adding the missing author value when restoring a backup ZIP file.