libcontainer: fix the file mode of the device#2804
Merged
kolyshkin merged 1 commit intoopencontainers:masterfrom Feb 22, 2021
Merged
libcontainer: fix the file mode of the device#2804kolyshkin merged 1 commit intoopencontainers:masterfrom
kolyshkin merged 1 commit intoopencontainers:masterfrom
Conversation
kolyshkin
reviewed
Feb 10, 2021
kolyshkin
previously approved these changes
Feb 10, 2021
Contributor
kolyshkin
left a comment
kolyshkin
left a comment
There was a problem hiding this comment.
LGTM except for one nit which is not important
Contributor
|
@Iceber can you please rebase (to test against go 1.16)? |
Signed-off-by: Iceber Gu <wei.cai-nat@daocloud.io>
AkihiroSuda
approved these changes
Feb 22, 2021
Member
|
@kolyshkin ptal |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The file mode of the device does not contain file type bits
mode &^ unix.S_IFMTshould be added when setting device.FileMode.Fix containerd: containerd/containerd#5028
Discussions about FileMode: opencontainers/runtime-spec#1082