Skip to content

Conversation

@gruebel
Copy link
Member

@gruebel gruebel commented Jan 29, 2026

This PR

  • I also added a tox style testing matrix for different Python version, which makes local testing pretty easy

Related Issues

Fixes #562

Follow-up Tasks

  • will do the same in contrib repo

Signed-off-by: gruebel <anton.gruebel@gmail.com>
@gruebel gruebel requested review from a team as code owners January 29, 2026 22:30
@gemini-code-assist
Copy link

Summary of Changes

Hello @gruebel, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the project's development workflow by adopting poethepoet as the primary task runner. This change streamlines script execution and introduces a comprehensive testing matrix to ensure compatibility across various Python environments. The update also includes routine dependency upgrades to maintain a modern and secure development setup.

Highlights

  • Task Runner Migration: The project's task management has been migrated from project.scripts to poethepoet, providing a more flexible and declarative way to define and run development tasks.
  • Tox-style Testing Matrix: A new tox-style testing matrix has been introduced using poethepoet, allowing for easy local testing across multiple Python versions (3.10 to 3.14) with a single command.
  • Dependency Updates: Several development dependencies have been updated to their latest versions, including coverage, cucumber-expressions, cucumber-tag-expressions, identify, packaging, and tomli. poethepoet and its dependency pastel have also been added.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/build.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the project's task runner from custom scripts to poethepoet, which is a positive change for maintainability and standardization. The introduction of a testing matrix for multiple Python versions is also a valuable addition. I've identified a critical issue in the e2e task where shell commands are not being used correctly for globbing, which will cause it to fail. I've also suggested a refactoring for the test matrix tasks to reduce duplication using poethepoet's parameterization feature. Overall, this is a good improvement for the project's development workflow.

Signed-off-by: gruebel <anton.gruebel@gmail.com>
@gruebel gruebel changed the title replace project.scripts with poethepoet fix: replace project.scripts with poethepoet Jan 29, 2026
@codecov
Copy link

codecov bot commented Jan 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.18%. Comparing base (45f7fd1) to head (5f4febb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #563   +/-   ##
=======================================
  Coverage   98.18%   98.18%           
=======================================
  Files          41       41           
  Lines        1982     1982           
=======================================
  Hits         1946     1946           
  Misses         36       36           
Flag Coverage Δ
unittests 98.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

un-runnable scripts aliasing common system executables (e.g. bin/test)

2 participants