rfc4: clarify coordinate direction convention #428
+11
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Automated Review URLs |
anterior-to-posterior is from negative to positive along the axis. negative to positive along the axis is defined by its spatial metadata. Requested: https://forum.image.sc/t/rfc-4-updates-enhanced-anatomical-orientation-support-for-ome-ngff/115625/6
thewtex
force-pushed
the
rfc-4-negative-to-positive
branch
from
a996b57 to
c8a64ff
Compare
Contributor
Author
|
This pull request has been mentioned on Image.sc Forum. There might be relevant details there: https://forum.image.sc/t/rfc-4-updates-enhanced-anatomical-orientation-support-for-ome-ngff/115625/9 |
Contributor
|
Good addition, clearly phrased imo, looks good! 👍 |
Contributor
|
Agree, definition is unambiguous now. LGTM! |
Contributor
|
Looks good! The only minor adjustment which might be useful is replacing "largest/"smallest" with "highest"/"lowest" or "closest to positive infinity"/"closest to negative infinity" as coordinate values won't necessarily start from 0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
anterior-to-posterior is from negative to positive along the axis.
negative to positive along the axis is defined by its spatial metadata.
Requested: https://forum.image.sc/t/rfc-4-updates-enhanced-anatomical-orientation-support-for-ome-ngff/115625/6