Fix current day and future month in SlashDMY#34
Fix current day and future month in SlashDMY#34mvgrimes wants to merge 2 commits intoolebedev:masterfrom
Conversation
If no year is specified, then nil is returned for: - current date July 15 in test - future months
|
Hello @mvgrimes, Thank you for your contribution. However, the change you propose contradicts the purpose of the I appreciate the idea of implementing such a rule, but I suggest creating a separate rule that is not enabled by default. The reason for this is that the tuples like Could you please rework it into a dedicated rule that is not enabled by default? Say, Best regards, |
|
If you are willing to continue with that, please do a git rebase over the resent |
|
Hi @olebedev, The dmy rule isn't really something that I'll ever use. I just noticed that it worked for d/m if they were in the past, but returned nil for the current date and future dates. If you're interested in merging my other patches (#35 and #19), then I can take a look at separating out the dm rule from the dmy rule when I have some time. |
|
Hi @mvgrimes, I would be more that happy to get your patches in! Please do. |
When handling DD/MM without a year, SlashDMY returns nil for the current date
(ie, 15/7 in the tests) or for any future months (ie, 14/8).
This pull request adds failing tests and fixes fixes SlashDMY.
Thanks for publishing this package. I've found it quite useful.