Added [Local Files] submenu section with [Upload...] submenu to upload file/folder to simulator/emulator/device#146
Open
xjki wants to merge 6 commits intookwasniewski:mainfrom
Open
Added [Local Files] submenu section with [Upload...] submenu to upload file/folder to simulator/emulator/device#146xjki wants to merge 6 commits intookwasniewski:mainfrom
xjki wants to merge 6 commits intookwasniewski:mainfrom
Conversation
…/file selection and upload via adb (+use deprecated MediaScanner broadcast to force reindex - see https://stackoverflow.com/questions/66929450/images-not-shown-in-photos-using-adb-push-pictures-to-android-11-emulator and https://stackoverflow.com/questions/64552886/adb-push-files-are-not-showing-on-android-11-emulator for reference).
…loads to phone internal storage /Downloads folder) actions
Owner
|
Hey @xjki thank you for working on this! Can you address few things? CI is not passing. + Here are few things from (ai based) code review:
In
I'm going to test it out and do a deeper check once these get resolved. |
Author
|
Thanks for review, I will fix these next week. |
Added fallback/checking to /sdcard/Downloads if /sdcard/Download does not exist. Fixed issues uploading files/folders containing spaces in name. Added tests. Added logger for debug purposes and warnings/errors.
Author
|
Check 3efeae9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
To make it easier to share files from Mac to simulator/emulator environments and physical devices, I have added [Local files] submenu section to iOS emulator, Android emulator and Android device menus with the [Upload...] action that allows you to select file or folder from Mac and upload it to simulator/emulator/device local storage. For Android emulator/device uploaded file/folder will land in the /Downloads folder. On iOS simulator uploaded file/folder will land in device's File Provider Local Storage container.
In addition added also [Open in Finder...] option that opens simulator's File Provider Local Storage container to make it even easier to copy/paste/share/remove files/folders from the iOS simulator local storage
Changelog:
Added [Local Files] submenu section with [Upload...] submenu to upload file/folder to simulator/emulator/device. Added extra [Open in Finder...] action to iOS simulator. Moved [Delete] action as last in the device menu.
Test Plan:
Runned tests. Tested with Mac OS Sequoia 15.7.3, iOS 18.6/iOS 26.2 simulators, Android 16 emulator, Android 16 device.