Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+128
to
+156
| function _recoverSigner(bytes32 hash, bytes memory signature) internal pure returns (address) { | ||
| require(signature.length == 65, "GrantsTokenFaucet: invalid signature length"); | ||
|
|
||
| bytes32 r; | ||
| bytes32 s; | ||
| uint8 v; | ||
|
|
||
| assembly { | ||
| r := mload(add(signature, 32)) | ||
| s := mload(add(signature, 64)) | ||
| v := and(mload(add(signature, 65)), 255) | ||
| } | ||
|
|
||
| // Prevent signature malleability: s must be in the lower half of the secp256k1 curve order | ||
| require(uint256(s) <= 0x7FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF5D576E7357A4501DDFE92F46681B20A0, | ||
| "GrantsTokenFaucet: invalid signature s value"); | ||
|
|
||
| // Handle v values 0-1 (EIP-155) and 27-28 (legacy) | ||
| if (v < 27) { | ||
| v += 27; | ||
| } | ||
|
|
||
| require(v == 27 || v == 28, "GrantsTokenFaucet: invalid signature v value"); | ||
|
|
||
| address recovered = ecrecover(hash, v, r, s); | ||
| require(recovered != address(0), "GrantsTokenFaucet: invalid signature recovery"); | ||
|
|
||
| return recovered; | ||
| } |
Check warning
Code scanning / Slither
Assembly usage Warning
add faucet for grants token
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # .
Changes proposed in this PR:
(see Distribute Grant tokens page - design and mock implementation nodes-dashboard#261)