Skip to content

cogs.log_analysis: Allow hardware display without check#17

Open
Penwy wants to merge 1 commit intoobsproject:masterfrom
Penwy:hardware-display
Open

cogs.log_analysis: Allow hardware display without check#17
Penwy wants to merge 1 commit intoobsproject:masterfrom
Penwy:hardware-display

Conversation

@Penwy
Copy link
Contributor

@Penwy Penwy commented Mar 12, 2026

Description

This allows the bot to display the hardware a submitted log is running on without needing to pass through a hardware database check.

Rather than reusing the pre-existing function for extracting hardware info from the log, this creates a new one, tailored for ease of maintenance through a potentially changing logging.
This is done by having the various patterns( for detection of the CPU/GPU, and for cleanup of the string before display) be easily accessible in a list rather than "buried" in a regex.

Motivation and Context

The hardware check was removed due to (from what I understand) the difficulty of maintaining a database compared to the usefulness of it. While that is valid, quite a few support volunteer have expressed that the ability to see the hardware used at a glance was useful, and that does not require the maintenance of a database.

How Has This Been Tested?

Ran against a collection of logs with various OS and hardware, verified the output was correct.
hardware_input.txt
hardware_output.txt

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@Penwy Penwy force-pushed the hardware-display branch from 9e6c1a5 to 4f0f644 Compare March 12, 2026 16:40
@Penwy Penwy force-pushed the hardware-display branch from 4f0f644 to 7d7dfa5 Compare March 12, 2026 16:42
@Penwy
Copy link
Contributor Author

Penwy commented Mar 12, 2026

The remaining linter errors are either :

  • from files that haven't been changed by this PR.
  • suggestions that I personally think would make the readability of important comments objectively worse.

If the project would rather have comments formatted as the linter suggest I will change it so, but for now, I'll leave as-is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant