cogs.log_analysis: Allow hardware display without check#17
Open
Penwy wants to merge 1 commit intoobsproject:masterfrom
Open
cogs.log_analysis: Allow hardware display without check#17Penwy wants to merge 1 commit intoobsproject:masterfrom
Penwy wants to merge 1 commit intoobsproject:masterfrom
Conversation
Contributor
Author
|
The remaining linter errors are either :
If the project would rather have comments formatted as the linter suggest I will change it so, but for now, I'll leave as-is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This allows the bot to display the hardware a submitted log is running on without needing to pass through a hardware database check.
Rather than reusing the pre-existing function for extracting hardware info from the log, this creates a new one, tailored for ease of maintenance through a potentially changing logging.
This is done by having the various patterns( for detection of the CPU/GPU, and for cleanup of the string before display) be easily accessible in a list rather than "buried" in a regex.
Motivation and Context
The hardware check was removed due to (from what I understand) the difficulty of maintaining a database compared to the usefulness of it. While that is valid, quite a few support volunteer have expressed that the ability to see the hardware used at a glance was useful, and that does not require the maintenance of a database.
How Has This Been Tested?
Ran against a collection of logs with various OS and hardware, verified the output was correct.
hardware_input.txt
hardware_output.txt
Types of changes
Checklist: