-
Notifications
You must be signed in to change notification settings - Fork 8
Add ncbitaxon:has_division property.
#133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Does divison have to be a PURL? it seems adding PURLS like http://purl.obolibrary.org/obo/NCBITaxon_Primates will create a lot of weird identifiers.. |
|
I'm actually ok with strings. I agree PURL would look weird. I wasn't sure. I'll roll it back for now. |
|
Rolled back, now Homo Sapiens looks like this: <!-- http://purl.obolibrary.org/obo/NCBITaxon_9606 -->
<owl:Class rdf:about="http://purl.obolibrary.org/obo/NCBITaxon_9606">
<rdfs:subClassOf rdf:resource="http://purl.obolibrary.org/obo/NCBITaxon_9605"/>
<ncbitaxon:has_division>Primates</ncbitaxon:has_division>
<ncbitaxon:has_rank rdf:resource="http://purl.obolibrary.org/obo/NCBITaxon_species"/>
<oboInOwl:hasDbXref>GC_ID:1</oboInOwl:hasDbXref>
<oboInOwl:hasExactSynonym>human</oboInOwl:hasExactSynonym>
<oboInOwl:hasOBONamespace>ncbi_taxonomy</oboInOwl:hasOBONamespace>
<rdfs:label>Homo sapiens</rdfs:label>
</owl:Class>
<owl:Axiom>
<owl:annotatedSource rdf:resource="http://purl.obolibrary.org/obo/NCBITaxon_9606"/>
<owl:annotatedProperty rdf:resource="http://www.geneontology.org/formats/oboInOwl#hasExactSynonym"/>
<owl:annotatedTarget>human</owl:annotatedTarget>
<oboInOwl:hasSynonymType rdf:resource="http://purl.obolibrary.org/obo/ncbitaxon#genbank_common_name"/>
</owl:Axiom>
``` |
|
@hrshdhgd I think I am missing some context from other peoples work.. @cthoyt @jamesamcl @anitacaron can someone remind what the deal is with these PURLs? Maybe we agreed this is indeed the right thing to do (sorry @hrshdhgd). |
|
Those non-numeric IDs are prehistoric, and we should not mint new ones going forward. |
I agree, that's why I was confused to see the purls for |
|
Is this Primates the same as this one? If so, we can use the same url then. |
This partially addresses #132
I have made minor tweaks to the code where I capture
divisionproperties from NCBITaxon'sdivision.dmpfile and add the property to all relevant classes.Homo Sapiensclass now looks like thisThe one doubt I have is should we capture this information as a string orI assigned them URIs (like it is done withhas_rank). Open to comments. If this is not acceptable, it's ok. Please let me know.