Added import for Price class and error handler to price and transacti…#9
Open
kpihus wants to merge 1 commit intooanda:masterfrom
Open
Added import for Price class and error handler to price and transacti…#9kpihus wants to merge 1 commit intooanda:masterfrom
kpihus wants to merge 1 commit intooanda:masterfrom
Conversation
joaocosta
reviewed
May 30, 2022
| var Field = require('./base').Field; | ||
|
|
||
| var pricing_common = require('./pricing_common'); | ||
| var Price = pricing_common.Price; |
There was a problem hiding this comment.
According to http://developer.oanda.com/rest-live-v20/pricing-ep/, this should be ClientPrice, not Price.
Note that the price stream endpoint returns the time field which class ClientPrice supports, but class Price does not.
In other words, the correct fix for this problem is at #16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…on streams