Open
Conversation
ddad8e4 to
cac7ee8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix duplicate logging in Rails 7.1+
Summary
BroadcastLoggerwrapping custom loggersbroadcast_tofrom adding additional log destinations that cause double loggingbroadcast_tono-op was applied too late (inafter_initialize) allowing gems like Sidekiq to add duplicate loggers before the fix was in placeProblem
In Rails 7.1+, the bootstrap process wraps custom loggers (like the
logginggem) in anActiveSupport::BroadcastLogger:Then various components call
Rails.logger.broadcast_to()to add additional log destinations:log_to_stdout) - adds console logger in developmentSidekiq.loggeras a broadcast sinkThis causes:
BroadcastLogger#method_missingcalls methods likewith_contexton each sink, executing the block multiple timesSolution
Add an initializer that runs after
:initialize_logger(when the BroadcastLogger is created) but before anyafter_initializehooks (where Sidekiq and others add their loggers):This ensures the no-op
broadcast_tois in place before any gem can add duplicate destinations.Timeline Comparison
Before (broken):
After (fixed):