Skip to content

Conversation

@romsi
Copy link
Contributor

@romsi romsi commented May 17, 2018

Goals ⚽

  • Having a simple structure where people can easily access the content that matters to them
  • Having minimum valuable content.

Inspiration 💡

@romsi romsi requested a review from damienfraud May 17, 2018 19:23
README.md Outdated
Guidelines and good practices for Medium publications
# Medium Guidelines

This guidelines are made for people who love writing amazing stories on Medium. As developers, we often miss the opportunity to get benefits from sharing our experiences, knowledge and thinking.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, correct with These guidelines. I also believe we should develop this introduction a bit more to be more explicit about the goal of this document.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, please go ahead.

README.md Outdated

This guidelines are made for people who love writing amazing stories on Medium. As developers, we often miss the opportunity to get benefits from sharing our experiences, knowledge and thinking.

This document intend to be clear, consistent and brief.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, correct with This document intends. Also, I'm not sure this should appear in the README. If the document intends to be clear, brief and consistent, readers should be able to see it without us having to specify it. If this was specified for possible contributors, then maybe this is something we should add in a CONTRIBUTING file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it because it helps reader to quickly understand the philosophy behind it. You can access to a particular section without needed to read the others. Checkout Raywenderlich style guide.

@damienfraud
Copy link

I added some comments already inside the content directly. To complement these, I really like the chapters set for this document, it sets up a nice base for the content. I also think we should start to think on defining labels (and maybe Milestones) for our pull requests, but maybe this is more of something to discuss inside PR #2.

@romsi
Copy link
Contributor Author

romsi commented May 18, 2018

I also think we should start to think on defining labels (and maybe Milestones) for our pull requests, but maybe this is more of something to discuss inside PR #2.

I do agree and we should create a CONTRIBUTING.md file where we define all these rules.

@romsi
Copy link
Contributor Author

romsi commented May 18, 2018

@damienfraud I do think if we have typo issues then we should correct them instantly, not waiting for authors to correct it.

@damienfraud
Copy link

I do think if we have typo issues then we should correct them instantly, not waiting for authors to correct it.

I agree, that is why checkout script has even more sense in those case (cf. my comment in PR #2). What do you think?

@romsi
Copy link
Contributor Author

romsi commented May 18, 2018

Check my answer.

damienfraud
damienfraud previously approved these changes May 18, 2018
@damienfraud
Copy link

damienfraud commented May 18, 2018

@romsi I added some changes to the introduction. Please, review before we can approve this PR.

@romsi romsi dismissed damienfraud’s stale review May 19, 2018 12:05

@damienfraud I was thinking about being explicit about that is based on our experiences, but I feel it should stay implicit. For example when you go to (Airbnb/javascript](https://github.com/airbnb/javascript) guideline repository, you know that it's based on their experiences. Being too explicit make people uncomfortable to contribute to it.

@romsi romsi changed the title Define the README file structure Define The README File Structure May 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants