-
Notifications
You must be signed in to change notification settings - Fork 0
Define The README File Structure #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
README.md
Outdated
| Guidelines and good practices for Medium publications | ||
| # Medium Guidelines | ||
|
|
||
| This guidelines are made for people who love writing amazing stories on Medium. As developers, we often miss the opportunity to get benefits from sharing our experiences, knowledge and thinking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, correct with These guidelines. I also believe we should develop this introduction a bit more to be more explicit about the goal of this document.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, please go ahead.
README.md
Outdated
|
|
||
| This guidelines are made for people who love writing amazing stories on Medium. As developers, we often miss the opportunity to get benefits from sharing our experiences, knowledge and thinking. | ||
|
|
||
| This document intend to be clear, consistent and brief. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, correct with This document intends. Also, I'm not sure this should appear in the README. If the document intends to be clear, brief and consistent, readers should be able to see it without us having to specify it. If this was specified for possible contributors, then maybe this is something we should add in a CONTRIBUTING file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it because it helps reader to quickly understand the philosophy behind it. You can access to a particular section without needed to read the others. Checkout Raywenderlich style guide.
|
I added some comments already inside the content directly. To complement these, I really like the chapters set for this document, it sets up a nice base for the content. I also think we should start to think on defining labels (and maybe Milestones) for our pull requests, but maybe this is more of something to discuss inside PR #2. |
I do agree and we should create a |
|
@damienfraud I do think if we have typo issues then we should correct them instantly, not waiting for authors to correct it. |
I agree, that is why checkout script has even more sense in those case (cf. my comment in PR #2). What do you think? |
|
@romsi I added some changes to the introduction. Please, review before we can approve this PR. |
@damienfraud I was thinking about being explicit about that is based on our experiences, but I feel it should stay implicit. For example when you go to (Airbnb/javascript](https://github.com/airbnb/javascript) guideline repository, you know that it's based on their experiences. Being too explicit make people uncomfortable to contribute to it.
Goals ⚽
Inspiration 💡