feat(timers deprecation): introduce #255

AugustinMauroy · 2025-10-30T10:42:38Z

Related issues:

Closes #241

AugustinMauroy · 2025-10-30T10:43:08Z

I need review on test cases so I can finish/clean the implementation

Copilot

Pull Request Overview

This PR introduces a comprehensive codemod recipe to migrate deprecated Node.js timers APIs to modern timer functions. The codemod replaces timers.enroll(), timers.unenroll(), timers.active(), and timers._unrefActive() with standard setTimeout(), clearTimeout(), and Timer#unref() constructs, addressing Node.js deprecations DEP0095, DEP0096, DEP0126, and DEP0127.

Key changes include:

New utility functions for GCD calculation and indent detection in the codemod-utils package
Five transformation modules that handle different deprecated APIs
Comprehensive test suite covering various import/require patterns
Automated cleanup of unused imports after transformations

Reviewed Changes

Copilot reviewed 45 out of 46 changed files in this pull request and generated 107 comments.

Show a summary per file

File	Description
utils/src/math.ts	Implements GCD function to calculate indentation units
utils/src/math.test.ts	Tests for GCD function including edge cases
utils/src/ast-grep/indent.ts	Detects indentation style and retrieves line indentation
utils/src/ast-grep/indent.test.ts	Tests for indentation detection utilities
utils/src/ast-grep/general.ts	Helper functions for AST manipulation
utils/src/ast-grep/general.test.ts	Tests for AST manipulation helpers
recipes/timers-deprecations/src/*.ts	Five transformation modules for each deprecated API
recipes/timers-deprecations/tests/**	Comprehensive test cases for all transformations
recipes/timers-deprecations/workflow.yaml	Workflow configuration for codemod execution
recipes/timers-deprecations/package.json	Package configuration and test scripts
recipes/timers-deprecations/codemod.yaml	Codemod metadata and registry configuration
recipes/timers-deprecations/README.md	Documentation with examples and caveats

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

utils/src/ast-grep/indent.test.ts

recipes/timers-deprecations/tests/active/expected/active_import-variants.js

recipes/timers-deprecations/tests/unref/expected/unref_import-variants.js

JakobJingleheimer

Thanks for this and sorry it's taken me a quite a while to get to it. It's been a helluva month :(

recipes/timers-deprecations/README.md

JakobJingleheimer · 2025-12-02T19:32:48Z

@AugustinMauroy I tried to review the rest of this, but the browser tab crashes trying to load it (it's big, but I didn't think it was that big). Would it be possible to break this into smaller pieces?

AugustinMauroy · 2025-12-10T10:01:17Z

@AugustinMauroy I tried to review the rest of this, but the browser tab crashes trying to load it (it's big, but I didn't think it was that big). Would it be possible to break this into smaller pieces?

I already do that. I just sub step for each deprecation + cleanup import

JakobJingleheimer

Thanks for this! Smaller PRs though please 🫠

I didn't review all the test files, but the implementation looks good! I don't understand how DEP0095 possibly works, but it has test coverage, so it obviously does 🤪

recipes/timers-deprecations/src/active-to-standard-timer.ts

JakobJingleheimer · 2025-12-31T16:18:09Z

recipes/timers-deprecations/src/active-to-standard-timer.ts

+			const indent = getLineIndent(sourceCode, statement.range().start.index);
+			const resourceText = resourceNode.text();
+			const childIndent = indent + indentUnit;
+			const innerIndent = childIndent + indentUnit;
+
+			const replacement =
+				`if (${resourceText}.timeout != null) {${EOL}` +
+				`${childIndent}clearTimeout(${resourceText}.timeout);${EOL}` +
+				`${indent}}${EOL}${EOL}` +
+				`${indent}${resourceText}.timeout = setTimeout(() => {${EOL}` +
+				`${childIndent}if (typeof ${resourceText}._onTimeout === "function") {${EOL}` +
+				`${innerIndent}${resourceText}._onTimeout();${EOL}` +
+				`${childIndent}}${EOL}` +
+				`${indent}}, ${resourceText}._idleTimeout);`;


Aw, that's nice :)

JakobJingleheimer · 2025-12-31T16:19:54Z

recipes/timers-deprecations/src/active-to-standard-timer.ts

+			if (!statement) continue;
+
+			if (handledStatements.has(statement.id())) continue;
+			handledStatements.add(statement.id());


I this line should go at the bottom just in case something goes wrong in the code below.

JakobJingleheimer · 2025-12-31T16:28:48Z

recipes/timers-deprecations/src/cleanup-imports.ts

+	'active',
+	'_unrefActive',
+] as const;
+const DEPRECATED_SET = new Set<string>(DEPRECATED_METHODS);


nit: manually setting the optional generic param actually works against it; without, typescript infers Set<"enroll" | "unenroll" | "active" | "_unrefActive"> 🙂

Suggested change

const DEPRECATED_SET = new Set<string>(DEPRECATED_METHODS);

const DEPRECATED_SET = new Set(DEPRECATED_METHODS);

JakobJingleheimer · 2025-12-31T16:29:45Z

recipes/timers-deprecations/src/cleanup-imports.ts

+		if (statement.kind() === 'expression_statement') {
+			continue;
+		}


nit for consistency

Suggested change

if (statement.kind() === 'expression_statement') {

continue;

}

if (statement.kind() === 'expression_statement') continue;

JakobJingleheimer · 2025-12-31T16:59:29Z

recipes/timers-deprecations/src/enroll-to-set-timeout.ts

+			if (!statement) continue;
+
+			if (handledStatements.has(statement.id())) continue;
+			handledStatements.add(statement.id());


Same: I'd put this at the end

JakobJingleheimer · 2025-12-31T17:03:37Z

recipes/timers-deprecations/src/unref-active-to-unref.ts

+			if (!statement) continue;
+
+			if (handledStatements.has(statement.id())) continue;
+			handledStatements.add(statement.id());


same: move to the end

JakobJingleheimer · 2025-12-31T17:04:22Z

recipes/timers-deprecations/tests/active/expected/active_import-variants.js

4 vs 2 indentation

I would collapse all the ifs etc into 1 line that are if x do y.

JakobJingleheimer · 2025-12-31T17:07:27Z

recipes/timers-deprecations/tests/active/expected/destructured.js

too much indentation here

JakobJingleheimer · 2025-12-31T17:08:53Z

recipes/timers-deprecations/tests/active/input/active_import-variants.js

too much indentation here

AugustinMauroy added 4 commits October 29, 2025 22:43

feat(timers-deprecations): scaffould

d81e531

update

7409e1b

Update cleanup-imports.ts

b679ff5

update and add more case

a88c1c4

AugustinMauroy mentioned this pull request Oct 30, 2025

spec(v22-to-v24): what we have to do #239

Open

18 tasks

AugustinMauroy added 3 commits October 31, 2025 14:35

fix: support of windows

b5635b5

split utility

bfc9b18

Merge branch 'main' into augustin/timers-deprecation

c3b4d51

AugustinMauroy requested review from a team and Copilot October 31, 2025 14:09

AugustinMauroy added awaiting reviewer Author has responded and needs action from the reviewer dep:v24 Migration handles deprecation introduced in node v24 dep:EoL Migration handles deprecation introduced in an EoL version of node labels Oct 31, 2025

Copilot AI reviewed Oct 31, 2025

View reviewed changes

AugustinMauroy linked an issue Nov 1, 2025 that may be closed by this pull request

feat: handle timers deprecation #241

Open

JakobJingleheimer reviewed Dec 1, 2025

View reviewed changes

recipes/timers-deprecations/README.md Outdated Show resolved Hide resolved

recipes/timers-deprecations/README.md Outdated Show resolved Hide resolved

recipes/timers-deprecations/README.md Outdated Show resolved Hide resolved

doc: use diff

3292eac

AugustinMauroy requested a review from a team December 15, 2025 19:32

JakobJingleheimer approved these changes Dec 31, 2025

View reviewed changes

JakobJingleheimer removed the awaiting reviewer Author has responded and needs action from the reviewer label Jan 1, 2026

AugustinMauroy added the awaiting author Reviewer has requested something from the author label Jan 9, 2026

	const DEPRECATED_SET = new Set<string>(DEPRECATED_METHODS);
	const DEPRECATED_SET = new Set(DEPRECATED_METHODS);

Uh oh!

feat(timers deprecation): introduce #255

Are you sure you want to change the base?

feat(timers deprecation): introduce #255

Conversation

AugustinMauroy commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related issues:

Uh oh!

AugustinMauroy commented Oct 30, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JakobJingleheimer left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JakobJingleheimer commented Dec 2, 2025

Uh oh!

AugustinMauroy commented Dec 10, 2025

Uh oh!

JakobJingleheimer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

AugustinMauroy commented Oct 30, 2025 •

edited

Loading

JakobJingleheimer left a comment •

edited

Loading